l.behm/bumblebee-status
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[modules/octoprint] small improvements based on code review

Browse source 
* no need to call update method in constructor of the module
* renamed method "update_status" to "update" to get rid off one
level of indirection
This commit is contained in:
Bernhard B 2020-05-03 16:03:59 +02:00
parent 9dd0eb58eb
commit 8761c09c19
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
modules/contrib/octoprint.py
View file

@ -73,8 +73,6 @@ class Module(core.module.Module):
self.__printer_bed_temperature = "-" self.__printer_bed_temperature = "-"
self.__tool1_temperature = "-" self.__tool1_temperature = "-"
self.update_status()
core.input.register(self, button=core.input.LEFT_MOUSE, core.input.register(self, button=core.input.LEFT_MOUSE,
cmd=self.__show_popup) cmd=self.__show_popup)
@ -120,7 +118,7 @@ class Module(core.module.Module):
tool_id += 1 tool_id += 1
return tool_temperatures return tool_temperatures
def update_status(self): def update(self):
try: try:
self.__octoprint_state = self.__get_octoprint_state() self.__octoprint_state = self.__get_octoprint_state()
@ -215,9 +213,6 @@ class Module(core.module.Module):
self.__webcam_images_queue = None self.__webcam_images_queue = None
self.__webcam_images_worker.stop() self.__webcam_images_worker.stop()
def update(self):
self.update_status()
def state(self, widget): def state(self, widget):
return [] return []