From 8761c09c192ea7c6fbbcd0a1366673c0d21587c0 Mon Sep 17 00:00:00 2001 From: Bernhard B Date: Sun, 3 May 2020 16:03:59 +0200 Subject: [PATCH] [modules/octoprint] small improvements based on code review * no need to call update method in constructor of the module * renamed method "update_status" to "update" to get rid off one level of indirection --- modules/contrib/octoprint.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/modules/contrib/octoprint.py b/modules/contrib/octoprint.py index 5e9a5da..53cbd8d 100644 --- a/modules/contrib/octoprint.py +++ b/modules/contrib/octoprint.py @@ -72,8 +72,6 @@ class Module(core.module.Module): self.__printer_bed_temperature = "-" self.__tool1_temperature = "-" - - self.update_status() core.input.register(self, button=core.input.LEFT_MOUSE, cmd=self.__show_popup) @@ -120,7 +118,7 @@ class Module(core.module.Module): tool_id += 1 return tool_temperatures - def update_status(self): + def update(self): try: self.__octoprint_state = self.__get_octoprint_state() @@ -215,9 +213,6 @@ class Module(core.module.Module): self.__webcam_images_queue = None self.__webcam_images_worker.stop() - def update(self): - self.update_status() - def state(self, widget): return []