l.behm/bumblebee-status
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[output] Ignore empty commands

Browse source 
When receiving a "nop" (None) command, skip it. Otherwise, an exception
is thrown and input processing stops.

Also, remove the "communicate()" call to *not* wait until a process has
finished until resuming input processing. Otherwise, whenever an
external program (pavucontrol, nautilius, ...) is started, any further
input processing is stalled until the program has been closed again.

fixes #24
This commit is contained in:
Tobi-wan Kenobi 2016-11-29 19:35:54 +01:00
parent 4819147410
commit bf381794bd
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
bumblebee/output.py
View file

@ -52,12 +52,13 @@ class Command(object):
self._command = [ self._command ] self._command = [ self._command ]
for cmd in self._command: for cmd in self._command:
if not cmd: continue
if inspect.ismethod(cmd): if inspect.ismethod(cmd):
cmd(self._event, self._widget) cmd(self._event, self._widget)
else: else:
c = cmd.format(*args, **kwargs) c = cmd.format(*args, **kwargs)
DEVNULL = open(os.devnull, 'wb') DEVNULL = open(os.devnull, 'wb')
subprocess.Popen(shlex.split(c), stdout=DEVNULL, stderr=DEVNULL).communicate() subprocess.Popen(shlex.split(c), stdout=DEVNULL, stderr=DEVNULL)
class Output(object): class Output(object):
def __init__(self, config): def __init__(self, config):