l.behm/bumblebee-status
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[output] Using "instance" for callback registration doesn't make sense

Browse source 
"instance" is actually better suited to be an argument to the callback
(which it already is) than part of the key for callback lookup.
This commit is contained in:
Tobias Witek 2016-11-01 07:58:50 +01:00
parent 7c2170f58a
commit a63094af47
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
bumblebee/output.py
View file

@ -4,30 +4,21 @@ class Output(object):
self._theme = theme
self._callbacks = {}
def add_callback(self, cmd, button, module=None, instance=None):
def add_callback(self, cmd, button, module=None):
self._callbacks[(
button,
module,
instance
)] = cmd
def callback(self, event):
cb = self._callbacks.get((
event.get("button", -1),
event.get("name", None),
event.get("instance", None)
), None)
if cb is not None: return cb
cb = self._callbacks.get((
event.get("button", -1),
event.get("name", None),
None
), None)
if cb is not None: return cb
cb = self._callbacks.get((
event.get("button", -1),
None,
None
), None)
return cb