From 7d8b659a55c9f325a84e3b0041f31c65fa0a9c47 Mon Sep 17 00:00:00 2001 From: tobi-wan-kenobi Date: Fri, 8 May 2020 16:12:34 +0200 Subject: [PATCH] [modules/smartstatus] Use common boolean format --- modules/contrib/smartstatus.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/modules/contrib/smartstatus.py b/modules/contrib/smartstatus.py index e730a9a..0d65422 100644 --- a/modules/contrib/smartstatus.py +++ b/modules/contrib/smartstatus.py @@ -8,7 +8,7 @@ Parameters: * smartstatus.display: how to display (defaults to 'combined', other choices: 'seperate' or 'singles') * smartstatus.drives: in the case of singles which drives to display, separated comma list value, multiple accepted (defaults to 'sda', example:'sda,sdc') - * smartstatus.shownames: boolean in the form of "True" or "False" to show the name of the drives in the form of sda, sbd, combined or none at all. + * smartstatus.show_names: boolean in the form of "True" or "False" to show the name of the drives in the form of sda, sbd, combined or none at all. """ import os @@ -20,6 +20,7 @@ import core.widget import core.decorators import util.cli +import util.format class Module(core.module.Module): @@ -30,7 +31,7 @@ class Module(core.module.Module): self.devices = self.list_devices() self.display = self.parameter("display", "combined") self.drives = self.parameter("drives", "sda") - self.show_names = self.parameter("show_names", "True") + self.show_names = util.format.asbool(self.parameter("show_names", True)) self.widgets(self.create_widgets()) def create_widgets(self): @@ -65,10 +66,10 @@ class Module(core.module.Module): def output(self, widget): device = widget.get("device") assessment = widget.get("assessment") - if self.show_names == "False": - widget.full_text("{}".format(assessment)) - else: + if self.show_names: widget.full_text("{}: {}".format(device, assessment)) + else: + widget.full_text("{}".format(assessment)) def state(self, widget): states = []