l.behm/bumblebee-status
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[modules/rss] fix insecure use of tempfile

Browse source 
fixes #850
This commit is contained in:
tobi-wan-kenobi 2022-02-11 13:44:10 +01:00
parent 8458eef1e6
commit 4f9553f7ea
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
bumblebee_status/modules/contrib/rss.py
View file

@ -55,7 +55,7 @@ class Module(core.module.Module):
self._state = [] self._state = []
self._newspaper_filename = tempfile.mktemp(".html") self._newspaper_file = tempfile.NamedTemporaryFile(mode="w", suffix=".html")
self._last_refresh = 0 self._last_refresh = 0
self._last_update = 0 self._last_update = 0
@ -308,10 +308,11 @@ class Module(core.module.Module):
while newspaper_items: while newspaper_items:
content += self._create_news_section(newspaper_items) content += self._create_news_section(newspaper_items)
open(self._newspaper_filename, "w").write( self._newspaper_file.write(
HTML_TEMPLATE.replace("[[CONTENT]]", content) HTML_TEMPLATE.replace("[[CONTENT]]", content)
) )
webbrowser.open("file://" + self._newspaper_filename) self._newspaper_file.flush()
webbrowser.open("file://" + self._newspaper_file.name)
self._update_history("newspaper") self._update_history("newspaper")
self._save_history() self._save_history()