l.behm/bumblebee-status
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

BUG: github module count breaks in python3

Browse source 
In python2, filter returned a list, but in python3 it returns an iterator. So
we wrap this in a list() so that it works in both.  We also want to count the
unread notifications, so this should be reflected in the code.
This commit is contained in:
Christopher Mullins 2017-09-17 18:46:40 -04:00
parent e079c07363
commit 42b42c1294
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bumblebee/modules/github.py
View file

@ -49,7 +49,7 @@ class Module(bumblebee.engine.Module):
url = "https://api.github.com/notifications" url = "https://api.github.com/notifications"
while True: while True:
notifications = self._requests.get(url) notifications = self._requests.get(url)
self._count += len(filter(lambda notification: notification.get("unread", False), notifications.json())) self._count += len(list(filter(lambda notification: notification['unread'], notifications.json())))
next_link = notifications.links.get('next') next_link = notifications.links.get('next')
if next_link is not None: if next_link is not None:
url = next_link.get('url') url = next_link.get('url')