[modules/publicip] handle missing public ip more gracefully

If location does not throw, but reports an empty public IP, return
"n/a".

Since this caused a bug, also add a test for it.

fixes #853
This commit is contained in:
tobi-wan-kenobi 2022-02-14 14:58:01 +01:00
parent b1f49f6a1e
commit 3aadab5628
2 changed files with 11 additions and 2 deletions

View file

@ -16,13 +16,13 @@ class Module(core.module.Module):
self.__ip = ""
def public_ip(self, widget):
return self.__ip
return self.__ip or "n/a"
def update(self):
try:
self.__ip = util.location.public_ip()
except Exception:
self.__ip = "n/a"
self.__ip = None
# vim: tabstop=8 expandtab shiftwidth=4 softtabstop=4