l.behm/bumblebee-status
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Support parsing zpool output for ZFS >=0.8.0

Browse source 
Query /sys/module/zfs/version for ZFS version and account for the
additional CKPOINT field in ZFS 0.8.0 and higher.
This commit is contained in:
Alex Boag-Munroe 2019-09-26 00:25:18 +01:00
parent e2e365c681
commit 3a2fcb1abf
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
bumblebee/modules/zpool.py
View file

@ -25,6 +25,7 @@ Be aware of security implications of doing this!
""" """
import time import time
from pkg_resources import parse_version
import bumblebee.engine import bumblebee.engine
from bumblebee.util import execute, bytefmt, asbool from bumblebee.util import execute, bytefmt, asbool
@ -64,6 +65,8 @@ class Module(bumblebee.engine.Module):
def _update_widgets(self, widgets): def _update_widgets(self, widgets):
# zpool list -H: List all zpools, use script mode (no headers and tabs as separators). # zpool list -H: List all zpools, use script mode (no headers and tabs as separators).
with open('/sys/module/zfs/version', 'r') as zfs_mod_version:
zfs_version = zfs_mod_version.readline().rstrip().split('-')[0]
raw_zpools = execute(('sudo ' if self._usesudo else '') + 'zpool list -H').split('\n') raw_zpools = execute(('sudo ' if self._usesudo else '') + 'zpool list -H').split('\n')
for widget in widgets: for widget in widgets:
@ -71,8 +74,11 @@ class Module(bumblebee.engine.Module):
for raw_zpool in raw_zpools: for raw_zpool in raw_zpools:
try: try:
# Ignored fields (assigned to _) are "expandsz" and "altroot" # Ignored fields (assigned to _) are "expandsz" and "altroot", also "ckpoint" in ZFS 0.8.0+
name, size, alloc, free, _, frag, cap, dedup, health, _ = raw_zpool.split('\t') if parse_version(zfs_version) < parse_version("0.8.0"):
name, size, alloc, free, _, frag, cap, dedup, health, _ = raw_zpool.split('\t')
else:
name, size, alloc, free, _, _, frag, cap, dedup, health, _ = raw_zpool.split('\t')
cap = cap.rstrip('%') cap = cap.rstrip('%')
percentuse=int(cap) percentuse=int(cap)
percentfree=100-percentuse percentfree=100-percentuse