[core/theme] slight improvements for clarity

core/theme.py

@@ -52,26 +52,27 @@ class Theme(object):
         if isinstance(name, dict): return name # support plain data
         for path in PATHS:
             theme_file = os.path.join(path, subdir, '{}.json'.format(name))
-            if os.path.isfile(theme_file):
+            result = self.__load_json(theme_file)
-                with io.open(theme_file, encoding='utf-8') as data:
+            if result != {}: return result
-                    return json.load(data)
         raise RuntimeError('unable to find theme {}'.format(name))
 
-    def __load(self, filename, sections):
+    def __load_json(self, filename):
-        result = {}
+        filename = os.path.expanduser(filename)
-        with io.open(os.path.expanduser(filename)) as data:
+        if not os.path.isfile(filename): return {}
-            colors = json.load(data)
+        with io.open(filename) as data:
-            for field in sections:
+            return json.load(data)
-                for key in colors.get(field, []):
-                    result[key] = colors[field][key]
-        return result
 
     def load_keywords(self, name):
         try:
             if isinstance(name, dict):
                 return name
             if name.lower() == 'wal':
-                return self.__load('~/.cache/wal/colors.json', ['special', 'colors'])
+                wal = self.__load_json('~/.cache/wal/colors.json')
+                result = {}
+                for field in ['special', 'colors']:
+                    for key in wal.get(field, {}):
+                        result[key] = wal[field][key]
+                return result
         except Exception as e:
             log.error('failed to load colors: {}', e)
 

doc/NOTES.md

@@ -28,6 +28,5 @@
 - github pages
 
 ## TODO
-- theme: `load` vs. `__load` vs. `load_keywords`
 - themes: use colors to improve theme readability
 - brightness: read from CLI tools