[tests] Refactor setting up complex I/O mocking for modules

Modules now only have to have a single setup/teardown line in their code
to fully set up the I/O part of a test.

tests/mocks.py

@@ -3,15 +3,36 @@
 import mock
 import json
 import shlex
+import random
 import subprocess
 
+from bumblebee.input import I3BarInput
 from bumblebee.output import Widget
-
+from bumblebee.config import Config
-import random
 
 def rand(cnt):
     return "".join(random.choice("abcdefghijklmnopqrstuvwxyz0123456789") for i in range(cnt))
 
+def setup_test(test, Module):
+    test._stdin, test._select, test.stdin, test.select = epoll_mock("bumblebee.input")
+
+    test.popen = MockPopen()
+
+    test.config = Config()
+    test.input = I3BarInput()
+    test.engine = mock.Mock()
+    test.engine.input = test.input
+    test.input.need_event = True
+    test.module = Module(engine=test.engine, config={ "config": test.config })
+    for widget in test.module.widgets():
+        widget.link_module(test.module)
+        test.anyWidget = widget
+
+def teardown_test(test):
+    test._stdin.stop()
+    test._select.stop()
+    test.popen.cleanup()
+
 def epoll_mock(module=""):
     if len(module) > 0: module = "{}.".format(module)
 

tests/modules/test_brightness.py

@@ -10,31 +10,15 @@ except ImportError:
 
 import tests.mocks as mocks
 
-from bumblebee.config import Config
+from bumblebee.input import WHEEL_UP, WHEEL_DOWN
-from bumblebee.input import I3BarInput, WHEEL_UP, WHEEL_DOWN
 from bumblebee.modules.brightness import Module
 
 class TestBrightnessModule(unittest.TestCase):
     def setUp(self):
-        self._stdin, self._select, self.stdin, self.select = mocks.epoll_mock("bumblebee.input")
+        mocks.setup_test(self, Module)
-
-        self.popen = mocks.MockPopen()
-
-        self.config = Config()
-        self.input = I3BarInput()
-        self.engine = mock.Mock()
-        self.engine.input = self.input
-        self.input.need_event = True
-
-        self.module = Module(engine=self.engine, config={ "config": self.config })
-        for widget in self.module.widgets():
-            widget.link_module(self.module)
-            self.anyWidget = widget
 
     def tearDown(self):
-        self._stdin.stop()
+        mocks.teardown_test(self)
-        self._select.stop()
-        self.popen.cleanup()
 
     def test_format(self):
         for widget in self.module.widgets():

tests/modules/test_caffeine.py

@@ -11,35 +11,19 @@ except ImportError:
 
 import tests.mocks as mocks
 
-import bumblebee.input
 from bumblebee.config import Config
-from bumblebee.input import I3BarInput, LEFT_MOUSE
+from bumblebee.input import LEFT_MOUSE
 from bumblebee.modules.caffeine import Module
 
 class TestCaffeineModule(unittest.TestCase):
     def setUp(self):
-        self._stdin, self._select, self.stdin, self.select = mocks.epoll_mock("bumblebee.input")
+        mocks.setup_test(self, Module)
-
-        self.popen = mocks.MockPopen()
-
-        self.input = I3BarInput()
-        self.engine = mock.Mock()
-        self.config = Config()
-        self.engine.input = self.input
-        self.engine.input.need_event = True
-
-        self.module = Module(engine=self.engine, config={ "config": self.config })
-        for widget in self.module.widgets():
-            widget.link_module(self.module)
-            self.anyWidget = widget
 
         self.xset_active = "  timeout:  0    cycle:  123"
         self.xset_inactive = "  timeout:  600    cycle:  123"
 
     def tearDown(self):
-        self._stdin.stop()
+        mocks.teardown_test(self)
-        self._select.stop()
-        self.popen.cleanup()
 
     def test_text(self):
         self.assertEquals(self.module.caffeine(self.anyWidget), "")

tests/modules/test_cmus.py

@@ -5,26 +5,12 @@ import unittest
 
 import tests.mocks as mocks
 
-from bumblebee.config import Config
+from bumblebee.input import LEFT_MOUSE
-from bumblebee.input import I3BarInput, LEFT_MOUSE
 from bumblebee.modules.cmus import Module
 
 class TestCmusModule(unittest.TestCase):
     def setUp(self):
-        self._stdin, self._select, self.stdin, self.select = mocks.epoll_mock("bumblebee.input")
+        mocks.setup_test(self, Module)
-
-        self.popen = mocks.MockPopen()
-
-        self.config = Config()
-        self.input = I3BarInput()
-        self.engine = mock.Mock()
-        self.engine.input = self.input
-        self.input.need_event = True
-
-        self.module = Module(engine=self.engine, config={ "config": self.config })
-        for widget in self.module.widgets():
-            widget.link_module(self.module)
-            self.anyWidget = widget
 
         self.songTemplate = """
 status {status}
@@ -40,9 +26,7 @@ tag comment comment
         """
 
     def tearDown(self):
-        self._stdin.stop()
+        mocks.teardown_test(self)
-        self._select.stop()
-        self.popen.cleanup()
 
     def test_read_song(self):
         self.popen.mock.communicate.return_value = ("song", None)

tests/modules/test_cpu.py

@@ -6,33 +6,18 @@ import mock
 
 import tests.mocks as mocks
 
-from bumblebee.config import Config
+from bumblebee.input import LEFT_MOUSE
-from bumblebee.input import I3BarInput, LEFT_MOUSE
 from bumblebee.modules.cpu import Module
 
 class TestCPUModule(unittest.TestCase):
     def setUp(self):
-        self._stdin, self._select, self.stdin, self.select = mocks.epoll_mock("bumblebee.input")
+        mocks.setup_test(self, Module)
-
-        self.popen = mocks.MockPopen()
         self._psutil = mock.patch("bumblebee.modules.cpu.psutil")
         self.psutil = self._psutil.start()
 
-        self.config = Config()
-        self.input = I3BarInput()
-        self.engine = mock.Mock()
-        self.engine.input = self.input
-        self.input.need_event = True
-        self.module = Module(engine=self.engine, config={ "config": self.config })
-        for widget in self.module.widgets():
-            widget.link_module(self.module)
-            self.anyWidget = widget
-
     def tearDown(self):
-        self._stdin.stop()
-        self._select.stop()
         self._psutil.stop()
-        self.popen.cleanup()
+        mocks.teardown_test(self)
 
     def test_format(self):
         self.psutil.cpu_percent.return_value = 21.0