Move knowledge from comments into constant names

This commit is contained in:
Philipp Matthias Schaefer 2020-02-02 20:54:38 +01:00
parent 19a1c177c6
commit 472d3995da

View file

@ -20,9 +20,11 @@ void setup(){
const int DELAY_TIME = 1000; const int DELAY_TIME = 1000;
const int THRESHOLD = 20; const int THRESHOLD = 20;
const int CLOSED_DOOR = 1;
const int OPEN_DOOR = 0;
int space_status = THRESHOLD / 2; int space_status = THRESHOLD / 2;
int space_status_b4 = 0; int published_door_state = OPEN_DOOR;
void print_status() { void print_status() {
Serial.print(" "); Serial.print(" ");
@ -43,11 +45,9 @@ void update_space_status_b4() {
// status check if we can switch the status. // status check if we can switch the status.
// low pass prevents waggling a bit // low pass prevents waggling a bit
if (space_status >= THRESHOLD-3) { if (space_status >= THRESHOLD-3) {
// closed space_status_b4 = CLOSED_DOOR;
space_status_b4 = 1;
} else if (space_status <= 3) { } else if (space_status <= 3) {
// open space_status_b4 = OPEN_DOOR;
space_status_b4 = 0;
} }
} }
@ -61,12 +61,10 @@ void loop(){
delay(DELAY_TIME); delay(DELAY_TIME);
// ampel / traffic light signals // ampel / traffic light signals
if (space_status_b4 == 1) { if (space_status_b4 == CLOSED_DOOR) {
// closed
digitalWrite(RED_LED_OUTPUT_PIN, HIGH); digitalWrite(RED_LED_OUTPUT_PIN, HIGH);
digitalWrite(GREEN_LED_OUTPUT_PIN, LOW); digitalWrite(GREEN_LED_OUTPUT_PIN, LOW);
} else if (space_status_b4 == 0) { } else if (space_status_b4 == OPEN_DOOR) {
// open
digitalWrite(RED_LED_OUTPUT_PIN, LOW); digitalWrite(RED_LED_OUTPUT_PIN, LOW);
digitalWrite(GREEN_LED_OUTPUT_PIN, HIGH); digitalWrite(GREEN_LED_OUTPUT_PIN, HIGH);
} }