fixed a game crashed because of lack of animations and improved the character class

front/src/Phaser/Entity/Character.ts

@@ -59,6 +59,7 @@ export abstract class Character extends Container {
                 frame?: string | number
     ) {
         super(scene, x, y/*, texture, frame*/);
+        this.PlayerValue = name;
 
         this.sprites = new Map<string, Sprite>();
 
@@ -73,10 +74,9 @@ export abstract class Character extends Container {
         });
         this.add(this.teleportation);*/
 
-        this.PlayerValue = name;
-        this.playerName = new BitmapText(scene, x, y - 25, 'main_font', name, 7);
+        this.playerName = new BitmapText(scene, 0,  - 25, 'main_font', name, 7);
         this.playerName.setOrigin(0.5).setCenterAlign().setDepth(99999);
-        scene.add.existing(this.playerName);
+        this.add(this.playerName);
 
         scene.add.existing(this);
 
@@ -88,8 +88,6 @@ export abstract class Character extends Container {
         this.getBody().setOffset(0, 8);
         this.setDepth(-1);
 
-        this.scene.events.on('postupdate', this.postupdate.bind(this));
-
         this.playAnimation(direction, moving);
     }
 
@@ -181,35 +179,21 @@ export abstract class Character extends Container {
         if (body.velocity.y < 0) { //moving up
             this.lastDirection = PlayerAnimationNames.WalkUp;
             this.playAnimation(PlayerAnimationNames.WalkUp, true);
-            //this.play(`${this.PlayerTexture}-${PlayerAnimationNames.WalkUp}`, true);
         } else if (body.velocity.y > 0) { //moving down
             this.lastDirection = PlayerAnimationNames.WalkDown;
             this.playAnimation(PlayerAnimationNames.WalkDown, true);
-            //this.play(`${this.PlayerTexture}-${PlayerAnimationNames.WalkDown}`, true);
         } else if (body.velocity.x > 0) { //moving right
             this.lastDirection = PlayerAnimationNames.WalkRight;
             this.playAnimation(PlayerAnimationNames.WalkRight, true);
-            //this.play(`${this.PlayerTexture}-${PlayerAnimationNames.WalkRight}`, true);
         } else if (body.velocity.x < 0) { //moving left
             this.lastDirection = PlayerAnimationNames.WalkLeft;
             this.playAnimation(PlayerAnimationNames.WalkLeft, true);
-            //this.anims.playReverse(`${this.PlayerTexture}-${PlayerAnimationNames.WalkLeft}`, true);
-        }
-
-        //todo:remove this, use a container tech to move the bubble instead
-        if (this.bubble) {
-            this.bubble.moveBubble(this.x, this.y);
         }
 
         //update depth user
         this.setDepth(this.y);
     }
 
-    postupdate(time: number, delta: number) {
-        //super.update(delta);
-        this.playerName.setPosition(this.x, this.y - 25);
-    }
-
     stop(){
         this.getBody().setVelocity(0, 0);
         this.playAnimation(this.lastDirection, false);
@@ -218,7 +202,6 @@ export abstract class Character extends Container {
     say(text: string) {
         if (this.bubble) return;
         this.bubble = new SpeechBubble(this.scene, this, text)
-        //todo make the bubble destroy on player movement?
         setTimeout(() => {
             if (this.bubble !== null) {
                 this.bubble.destroy();
@@ -228,9 +211,6 @@ export abstract class Character extends Container {
     }
 
     destroy(): void {
-        if (this.scene) {
-            this.scene.events.removeListener('postupdate', this.postupdate.bind(this));
-        }
         for (const sprite of this.sprites.values()) {
             if(this.scene) {
                 this.scene.sys.updateList.remove(sprite);

front/src/Phaser/Entity/SpeechBubble.ts

@@ -1,16 +1,12 @@
 import Scene = Phaser.Scene;
 import {Character} from "./Character";
 
+//todo: improve this WIP
 export class SpeechBubble {
     private bubble: Phaser.GameObjects.Graphics;
     private content: Phaser.GameObjects.Text;
 
-    /**
-     *
-     * @param scene
-     * @param player
-     * @param text
-     */
+    
     constructor(scene: Scene, player: Character, text: string = "") {
 
         const bubbleHeight = 50;
@@ -19,6 +15,7 @@ export class SpeechBubble {
         const arrowHeight = bubbleHeight / 4;
 
         this.bubble = scene.add.graphics({ x: player.x + 16, y: player.y - 80 });
+        player.add(this.bubble);
 
         //  Bubble shadow
         this.bubble.fillStyle(0x222222, 0.5);
@@ -53,30 +50,12 @@ export class SpeechBubble {
         this.bubble.lineBetween(point1X, point1Y, point3X, point3Y);
 
         this.content = scene.add.text(0, 0, text, { fontFamily: 'Arial', fontSize: '20', color: '#000000', align: 'center', wordWrap: { width: bubbleWidth - (bubblePadding * 2) } });
+        player.add(this.content);
 
         const bounds = this.content.getBounds();
         this.content.setPosition(this.bubble.x + (bubbleWidth / 2) - (bounds.width / 2), this.bubble.y + (bubbleHeight / 2) - (bounds.height / 2));
     }
 
-    /**
-     *
-     * @param x
-     * @param y
-     */
-    moveBubble(x : number, y : number) {
-        if (this.bubble) {
-            this.bubble.setPosition((x + 16), (y - 80));
-        }
-        if (this.content) {
-            const bubbleHeight = 50;
-            const bubblePadding = 10;
-            const bubbleWidth = bubblePadding * 2 + this.content.text.length * 10;
-            const bounds = this.content.getBounds();
-            //this.content.setPosition(x, y);
-            this.content.setPosition(this.bubble.x + (bubbleWidth / 2) - (bounds.width / 2), this.bubble.y + (bubbleHeight / 2) - (bounds.height / 2));
-        }
-    }
-
     destroy(): void {
         this.bubble.setVisible(false) //todo find a better way
         this.bubble.destroy();